Add METHOD target for use with AutoValue's abstract property methods #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
added a commit
that referenced
this pull request
Aug 14, 2015
Add METHOD target for use with AutoValue's abstract property methods
| @@ -64,7 +64,7 @@ | |||
| * @author Joel Leitch | |||
| */ | |||
| @Retention(RetentionPolicy.RUNTIME) | |||
| @Target(ElementType.FIELD) | |||
| @Target({ElementType.FIELD, ElementType.METHOD}) | |||
There was a problem hiding this comment.
@swankjesse Do we really want to do this?
If we allow SerializedName on methods, we should actually support it in full.
We Don't and we seem to have no plans to support it either. So, why open it up?
|
It's a pragmatic solution to the problem AutoValue users have. I don't think it obligates us to doing getters and setters, and I'm quite against doing that! |
|
Details are here: #687 |
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #687